Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PJM production parser #4871

Merged
18 commits merged into from
Dec 19, 2022
Merged

Upgrade PJM production parser #4871

18 commits merged into from
Dec 19, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 15, 2022

Issue

see Linear issue ELE-1281

Description

In the last data quality report, we noticed that there were many missing production data points for PJM. It seems like the current parser cannot collect data points at 4AM each day and sometimes for multiple hours.
I investigated and found that our production parser is a live parser so there is no way to get data for the missing points. There is an API however and it would be better to use it to get production (we get consumption forecast this way). This will enable us to backfill and get a more consistent dataset over time and potentially capture any data revisions.
This API can also be used to get LMP prices but would require a bit more work.

Preview

NA

@ghost ghost requested review from VIKTORVAV99 and pierresegonne December 15, 2022 17:44
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments on the new parts of the parser but I would like to take the oppertunity to clean up the old parts of the parser as well if you don't mind. I can get this done on friday.

parsers/US_PJM.py Outdated Show resolved Hide resolved
parsers/US_PJM.py Outdated Show resolved Hide resolved
parsers/US_PJM.py Outdated Show resolved Hide resolved
parsers/US_PJM.py Outdated Show resolved Hide resolved
parsers/US_PJM.py Outdated Show resolved Hide resolved
parsers/US_PJM.py Outdated Show resolved Hide resolved
parsers/US_PJM.py Outdated Show resolved Hide resolved
parsers/US_PJM.py Outdated Show resolved Hide resolved
parsers/US_PJM.py Outdated Show resolved Hide resolved
Mathilde Daugy and others added 9 commits December 16, 2022 09:14
Co-authored-by: Viktor Andersson <[email protected]>
Co-authored-by: Viktor Andersson <[email protected]>
Co-authored-by: Viktor Andersson <[email protected]>
Co-authored-by: Viktor Andersson <[email protected]>
Co-authored-by: Viktor Andersson <[email protected]>
Co-authored-by: Viktor Andersson <[email protected]>
Co-authored-by: Viktor Andersson <[email protected]>
Co-authored-by: Viktor Andersson <[email protected]>
@VIKTORVAV99
Copy link
Member

@mathilde-daugy I cleaned up the usage of session a bit (I hope that's okay) but feel free to revert it if needed.

@ghost
Copy link
Author

ghost commented Dec 16, 2022

@mathilde-daugy I cleaned up the usage of session a bit (I hope that's okay) but feel free to revert it if needed.

Thanks Viktor :)
I'll take a look on Monday, we're going to make a few adjustments as well before deploying

@ghost ghost requested a review from unitrium December 19, 2022 08:32
Copy link
Contributor

@unitrium unitrium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small code feedbacks but otherwise looks great!

parsers/US_PJM.py Outdated Show resolved Hide resolved
parsers/US_PJM.py Outdated Show resolved Hide resolved
parsers/US_PJM.py Outdated Show resolved Hide resolved
@ghost ghost merged commit 7f0f9ed into master Dec 19, 2022
@ghost ghost deleted the fix_pjm_production_parser branch December 19, 2022 10:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants